Coding style...

Finally got rslogix updated, unlocked and running on my new laptop and started re-learning all the stuff I've forgotten since I used it about 9 years ago!

I've attached a screenshot below as I don't know how to get nice clean ladder samples uploaded

Could someone let me know if the style of coding is reasonable, I like labeling ins & outs etc so i can find them easily, addresses that are not referenced elsewhere like OSR bits are left blank.

The section shown is the one discussed in my "Flip-Flop" thread.

Thanks

Dave,

The "style" of your code is of course secondary to function and will develop and evolve as you practice your craft. I wouldn't worry about it. Does it make sense to you? Will it make sense to you if you look at it a year from now, at 3am and a couple in? Can your friendly local maintenance tech understand it? Does it work? These are the questions you should be asking yourself.

For my part, the way you have used descriptions, symbols, and comments looks fine to me.

On another note, your rung 4....while there is nothing technically incorrect about your rung, it will certainly change the state of O:4/01 each time B3:0/03 fires, but the way it is written hurts my brain. Think how that rung would look to a non-programmer who had never seen a flip-flop. The rung looks self-contradicting at first glance. Try pasting this in its place and see if it doesn't look better:


The above is actually two less instructions than your rung, because it eliminates an unnecessary BST/NXB pair.

Thanks for that, i see what you mean with rung 4, I have transplanted your version and it does look clearer.