tomalbright
Member
I am confused by the "straight logic" remark, are you saying that a single sub-routine of 1000 rungs of logic is easier to follow than 10 sub-routines of 100 rungs each? I certainly don't agree with that, but then it's personal preference at that point.
I agree with you! In this instance, for a test run I replaced the code that set up the subroutine, and put the applicable rungs in instead, and used far less rungs that was initially involved in both the setup and the subroutine. The setup rungs were longer than the subroutine. There was seemingly a lack of brains involved.
While I like a "package", in this environment it needs to fit a little better. We also have the "bible", a set of SAFE charts that HAS to be followed. On other platforms I've seen this set apart as a program section, and it's easy to check and follow. Here, it's shotgunned throughout. I couldn't tell you where any particular function is without searching.
I like simple. Here we don't have process control like other places, and the need to troubleshoot and put the system back online is hindered by the way the code is written. That's just an observation of mine... other programmers who have worked on this have also called it "bad" so maybe it's not just me.