Regulating depending on incoming value

Someone asked me this:
When the level (analogue input) is above 10% then Valve Q4.0 must be open. Valve Q4.1 must be open when the level is less then 95%. Then he wanted in MD104 a setpoint depending on the level. So below 10% MD104 must be 0, between 10 and 80% MD104 must be 100, between 80 and 90% he wants 50 in MD104, between 90 and 95% he wants 30 in MD104 and between 95 and 100% he wanted 10 in MD104.

So I wrote this :::: (anyone who can simplify it in an other way or sow, just curieous how you guys would do it).



L MD 200 // Analoge ingang
ITD
DTR
L 2.764800e+004
/R
L 1.000000e+002
*R
T MD 100 // Gescaleerde waarde 0-100%

L 1.000000e+001
>R
= Q 4.0 // Aansturing klep 1
TAK
L 9.500000e+001
<R
= Q 4.1 // Aansturing klep 2
L MD 100
L 1.000000e+001
<R
JCN NO3
L 0.000000e+000
T MD 104
BE
NO3: L MD 100
L 1.000000e+001
>R
JCN NO4
L MD 100
L 8.000000e+001
<R
JCN NO4
L 1.000000e+002
T MD 104
BE
NO4: L MD 100
L 8.000000e+001
>R
JCN NO5
L MD 100
L 9.000000e+001
<R
JCN NO5
L 5.000000e+001
T MD 104
BE
NO5: L MD 100
L 9.000000e+001
>R
JCN NO6
L MD 100
L 9.500000e+001
<R
JCN NO6
L 3.000000e+001
T MD 104
BE
NO6: L MD 100
L 9.500000e+001
>R
JCN BE
L MD 100
L 1.000000e+002
<R
JCN BE
L 1.000000e+001
T MD 104
BE: BE

Here's a quick go I had at it, it's a bit shorter, whether it's easier to follow is a matter of opinion!



Kevin H

I would do it this way:


after scalling:


-----
L 0
T MD 104
L MD 100
L 10
<R
BEC
L 100
T MD 104
L MD 100
L 80
<R
BEC
L 50
T MD 104
L MD 100
L 90
<R
BEC
L 30
T MD 104
L MD 100
L 95
<R
BEC
L 10
T MD 104
BE
----------

28 lines vs 51 lines in your code


P.S. I guess comparing input <0 and >27648 is in another place

Is this a real application ? if so , you may wish to consider what happens when the value of the level is just on 10 and fluctuating - that poor old valve might chatter all over the place .

If this is a real application , you may wish to "debounce" the analogue input , "dead band" it to prevent this .

No

No, just an example for a school

Hey dude

Hey dude, I agree with your code, but, it's easy to write it that short if u eliminate the outputs Q4.0 and 4.1 and the scaling...

I like krk his method

a quick effort

Combo,

it has nothing to do with scalling and q4.0, q4.1, i did not include it assuming that i'm agree with your way of scalling, so whole decision would be:

L MD 200 // Analoge ingang
ITD
DTR
L 2.764800e+004
/R
L 1.000000e+002
*R
T MD 100 // Gescaleerde waarde 0-100%
L 1.000000e+001
>R
= Q 4.0 // Aansturing klep 1
TAK
L 9.500000e+001
<R
= Q 4.1 // Aansturing klep 2L 0
T MD 104
L MD 100
L 10
<R
BEC
L 100
T MD 104
L MD 100
L 80
<R
BEC
L 50
T MD 104
L MD 100
L 90
<R
BEC
L 30
T MD 104
L MD 100
L 95
<R
BEC
L 10
T MD 104
BE


so 41 lines vs 66 lines in your code

so i'm not sure what you mean by "it's easy to write it that short if u eliminate the outputs Q4.0 and 4.1 and the scaling..."

hey Peter

Hey Peter, great code !!!!

girevik

girevik,

Sowry dude, you're right

gerivik

girevik

I used you're way of thinking, end the function when a compare is okay. It's also great code, even better.

girevik said:

so 41 lines vs 66 lines in your code

Click to expand...

just 39 lines if you simplify the scaling....


L MD 200
ITD
DTR
L 2.764800e+002
/R
T MD 100

and even 2 lines shorter if to put q4.0/q4.1 into another place:

SET
S Q 4.1
L MD 200
ITD
DTR
L 2.764800e+002
/R
T MD 100
L 0 //missed in my previous post
T MD 104
L MD 100
L 1.000000e+001
<R
R Q 4.0
BEC
S Q 4.0
L 100
T MD 104
L MD 100
L 8.000000e+001
<R
BEC
L 50
T MD 104
L MD 100
L 9.000000e+001
<R
BEC
L 30
T MD 104
L MD 100
L 9.500000e+001
<R
BEC
R Q 4.1
L 10
T MD 104
BE

Instead of doing loads of comparisons, I would create a look-up table that specifies the setpoint level and convert the percentage into the index into the look up table.

tnx

tnx all

great code u guys can write !!!

THANKS a lot for letting me learn something !!!